[Tile-serving] [osm2pgsql] Make more of osm2pgsql threading aware (#110)
apmon
notifications at github.com
Sun Dec 15 17:39:07 UTC 2013
Thanks for having a look at the code and doing a review.
Regarding mallocs: The previous code had a lot of static variables, such that the memory only needed to be malloced once and could then be reused. The static variables were obviously not thread safe and needed to be replaced. The correct thing to do would probably be to allocate some "temporary buffer space" on the thread context and then re-use that per thread.
I don't know what the performance implications of those many mallocs are, but I have wondered if they do contribute to scaling issues. So it is on my todo list to try and get rid of as many as possible. I just haven't gotten around to doing this.
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/110#issuecomment-30613890
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20131215/e36b7a42/attachment.html>
More information about the Tile-serving
mailing list