[Tile-serving] [osm2pgsql] Conversion to C++ (#187)

[Paul Norman]

> Is this branch planned for inclusion in near future?

We hope so, but up to maintainers.

> do you plan to use c++ protobuf instead of protobuf-c (may be slower or not) ?

We didn't look at substantial rewrites to the parsers for a full conversion of them from C to modern C++. Given in a typical import, only a small portion is taken up by processing and of that, only a small portion is CPU-bound, so I'd rather have clarity in code than the last 10% speed or whatever we could potentially lose by rewriting that cleaner.

> The initial Windows-cpp version passes almost all the tests (fails 8+1 err, most - rounding)

That's surprisingly good. We probably need to revisit any tests using an equality check with floats.

> (can not turn off c++11 on MSVC and boost thinks that std::pair is not assignable - removed that check from boost sources to build).

That's surprising that you can't use C++98. In some ways, we'd of preferred to have used C++11, but there are enough servers out there which don't have recent enough compilers (Ubuntu 12.04).

If you can cherry-pick the non-cmake commits out and PR them against the branch in the mapquest repo, we should be able to get them fixed in this PR - just make sure that `make check` passes on linux-based systems.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/187#issuecomment-57339779
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20140930/0b302acc/attachment.html>