[Tile-serving] [osm2pgsql] Add an option to specify the target schema for import (#279)

Paul Norman notifications at github.com
Tue Jul 7 01:33:00 UTC 2015


> @@ -12,10 +12,10 @@ using std::string;
>  
>  table_t::table_t(const string& conninfo, const string& name, const string& type, const columns_t& columns, const hstores_t& hstore_columns,
>      const int srid, const int scale, const bool append, const bool slim, const bool drop_temp, const int hstore_mode,
> -    const bool enable_hstore_index, const boost::optional<string>& table_space, const boost::optional<string>& table_space_index) :
> +    const bool enable_hstore_index, const boost::optional<string>& table_space, const boost::optional<string>& table_space_index, const boost::optional<string>& schema) :

I had a look, moving to `table_options_t` would get `hstore_columns`, `hstore_mode`, `enable_hstore_index`, `tblsmain_data`, and `tblsmain_index` into one struct for sure.

`name`, `type`, `columns`, and `SRID` aren't part of `options_t` but might make sense in `table_options_t`, but would definitely differ between different tables, even in the pgsql backend.

`conninfo` could be per table (and probably should, as it opens up interesting options), but might require more work to move.

`append`, `slim` and `droptemp` are needed by the table constructor, but have more impact on the *middle* tables, not the output ones.

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/279/files#r34001225
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20150706/48ca70a3/attachment.html>


More information about the Tile-serving mailing list