[Tile-serving] [openstreetmap/osm2pgsql] Lua function errors now trigger runtime exception (#845)

[mmd]

I don't know exactly why errors in Lua processing are only sent to stderr and processing continues. There could be some nasty issues overflowing the stack and causing other types of corruption. I have changed those messages to runtime errors now. Maybe there some reasons why this doesn't make sense, in which case I'm happy to revert that part of this PR.

Also, I added some error handling for lua_tostring with details about incorrect data type. Instead of throwing some strange exception as in #664, processing now aborts with the following message.

`Osm2pgsql failed due to ERROR: Basic tag processing returned NULL value. Possibly this is due an incorrect data type 'boolean'.`

Fixes #664
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/osm2pgsql/pull/845

-- Commit Summary --

  * Lua function errors now trigger runtime exception

-- File Changes --

    M tagtransform-lua.cpp (38)

-- Patch Links --

https://github.com/openstreetmap/osm2pgsql/pull/845.patch
https://github.com/openstreetmap/osm2pgsql/pull/845.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/845
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20180422/d2c24bd7/attachment.html>