[Tile-serving] [openstreetmap/osm2pgsql] Make sure cache is freed before starting indexing (#813)

[Marcos Dione]

StyXman commented on this pull request.



> @@ -390,20 +390,22 @@ void osmdata_t::stop() {
     // should be the same for all outputs
     const bool append = outs[0]->get_options()->append;
 
-    //threaded pending processing
-    pending_threaded_processor ptp(mid, outs, outs[0]->get_options()->num_procs,
-                                   append);
-
-    if (!outs.empty()) {
-        //This stage takes ways which were processed earlier, but might be
-        //involved in a multipolygon relation. They could also be ways that
-        //were modified in diff processing.
-        mid->iterate_ways( ptp );
-
-        //This is like pending ways, except there aren't pending relations
-        //on import, only on update.
-        //TODO: Can we skip this on import?
-        mid->iterate_relations( ptp );
+    {

I would add a comment about why this block; at least for me, coming from Python, it's slightly strange. Otherwise, I would make the secondary effects more explicit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/813#pullrequestreview-89426825
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20180117/103b648e/attachment.html>