[Tile-serving] [openstreetmap/osm2pgsql] Add more way tests for flex output (#1249)
Sarah Hoffmann
notifications at github.com
Tue Jul 14 07:35:36 UTC 2020
@lonvia commented on this pull request.
> + "w15 v1 dV Tt=ag Nn17,n19",
+ "r30 v1 dV Tt=ag Mw10@,w11@,w12 at mark,w13@,w14 at mark"};
+
+// adding relation (marked), also check case where relation changed to contain
+// the way under test
+
+TEST_CASE("test way: add relation with way in t1 (marked)")
+{
+ options_t options = testing::opt_t().slim().flex(conf_file);
+
+ testing::data_t data{tdata};
+
+ data.add("w10 v1 dV Tt1=yes,t2=yes Nn10,n11");
+
+ SECTION("no relation") {}
+ SECTION("relation without w10") { data.add("r32 v1 dV Tt=ag Mw15@"); }
We are missing the indirect dependencies through members here. r32 should have the other ways as members, when it gets changed. This should then cover the last error case we have seen (the one that resulted in #1244). Unfortunately that means that we need separate functions. :(
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1249#pullrequestreview-447860027
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20200714/89e32720/attachment.htm>
More information about the Tile-serving
mailing list