[Tile-serving] [openstreetmap/osm2pgsql] Use std::system_error instead of runtime_error/strerror (PR #1634)
Jochen Topf
notifications at github.com
Wed Feb 2 13:11:18 UTC 2022
`std::strerror()` is not thread-safe, so it is best avoided. Also the output of the error messages will be more uniform this way.
There is one other case where we use `strerror()` (in [expire-tiles.cpp](https://github.com/openstreetmap/osm2pgsql/blob/master/src/expire-tiles.cpp#L44)) but that's only a warning, so we can't replace it by `system_error`, although maybe it shouldn't be a warning? Leaving that for later, the expire code needs some work anyway.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/osm2pgsql/pull/1634
-- Commit Summary --
* Use std::system_error instead of runtime_error/strerror
-- File Changes --
M src/node-persistent-cache.cpp (7)
M src/taginfo.cpp (11)
-- Patch Links --
https://github.com/openstreetmap/osm2pgsql/pull/1634.patch
https://github.com/openstreetmap/osm2pgsql/pull/1634.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1634
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/osm2pgsql/pull/1634 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20220202/5c602e73/attachment.htm>
More information about the Tile-serving
mailing list