[Tile-serving] [openstreetmap/osm2pgsql] Introduce behaviour-driven testing for integration tests (PR #1670)

[Sarah Hoffmann]

> I needed tests/bdd/steps/__pycache__ in .gitignore. The tests/__pycache__ can be removed I think.

Done.

> The test/bdd directory contains the tests themselves (flex, parameters, regression) as well as the "infrastructure" (environment.py, steps) which I find slightly confusing.

The directory layout is prescribed by behave. We could change some of it but I don't know what side-effects that has. I'd rather go with the standard here.

>  Also parameters is very general, maybe command-line or so?

Done

> There are several tests with a single input node that is just there so that some data is imported, it isn't checked what. Does it make sense to special case this somehow?

I've looked into this and it is not really random data that gets imported. In `command-line/dsn.feature` and `command-line/schema.feature` exactly one data point is expected, so 'Given some OSM data` would not specific enough.. That leaves only `command-line/invalid.feature`. In the end it's probably better to have the actual data as a remainder in the feature file. By writing it into the 'Background' section, the repetition can be kept to a minimum.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1670#issuecomment-1122107868
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/osm2pgsql/pull/1670/c1122107868 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20220510/56de87e3/attachment-0001.htm>