[Tile-serving] [openstreetmap/osm2pgsql] Use min/max in expire and remove superfluous check (PR #1808)

Sarah Hoffmann notifications at github.com
Thu Nov 3 08:12:54 UTC 2022


@lonvia commented on this pull request.



> @@ -200,26 +200,18 @@ int expire_tiles::from_bbox(geom::box_t const &box)
     }
 
     /* Convert the box's Mercator coordinates into tile coordinates */
-    auto const tmp_min = coords_to_tile({box.min_x(), box.max_y()});
-    int min_tile_x = tmp_min.x() - tile_expiry_leeway;
-    int min_tile_y = tmp_min.y() - tile_expiry_leeway;
+    auto const tmp_min = coords_to_tile(box.min());

This code is not the same. box.min() returns `min_y` while the old code has `max_y`. Is this a problem?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1808#pullrequestreview-1166442042
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/osm2pgsql/pull/1808/review/1166442042 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20221103/4e9e68f8/attachment-0001.htm>


More information about the Tile-serving mailing list