[Tile-serving] [openstreetmap/osm2pgsql] Use min/max in expire and remove superfluous check (PR #1808)
Jochen Topf
notifications at github.com
Thu Nov 3 16:26:41 UTC 2022
@joto commented on this pull request.
> @@ -200,26 +200,18 @@ int expire_tiles::from_bbox(geom::box_t const &box)
}
/* Convert the box's Mercator coordinates into tile coordinates */
- auto const tmp_min = coords_to_tile({box.min_x(), box.max_y()});
- int min_tile_x = tmp_min.x() - tile_expiry_leeway;
- int min_tile_y = tmp_min.y() - tile_expiry_leeway;
+ auto const tmp_min = coords_to_tile(box.min());
Yes it is! Now that we have tests (from another recently added PR) we can immediately see that they fail!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1808#discussion_r1013136717
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/osm2pgsql/pull/1808/review/1167277422 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20221103/06eb7d4c/attachment.htm>
More information about the Tile-serving
mailing list