[Tilesathome] Compress.pm and zip file names

Florian Lohoff flo at rfc822.org
Mon Sep 1 15:15:00 BST 2008


On Mon, Sep 01, 2008 at 11:23:46AM +0200, Dirk-Lüder Kreie wrote:
> Subject: [Tilesathome] Compress.pm and zip file names
> 
> Hi,
> I'm back and catching up with the latest flurry of client changes.
> 
> All in all I'm quite pleased with the way the client is going, 
> especially the code-cleanup. But I also see some issues wich had been 
> addressed already creep back (rename vs. move for example).
> 
> I blame insufficient code comments for that (and yes, I'm responsible 
> for quite a few there)
> 
> Now to the point of this e-mail:
> In Compress.pm we do take care to lock everything that could be 
> problematic on multi-client setups, why then go through the hassle of 
> zipping to temporary file names, which on some setups won't work because 
> the zip program will add ".zip" to the filename there by itself?

You have a directory for all the jobs tempfiles - the zip should go
there and will not clash with any other client by design.

Flo
-- 
Florian Lohoff                  flo at rfc822.org             +49-171-2280134
	Those who would give up a little freedom to get a little 
          security shall soon have neither - Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.openstreetmap.org/pipermail/tilesathome/attachments/20080901/deb5f42c/attachment.pgp>


More information about the Tilesathome mailing list