[Tilesathome] Compress.pm and zip file names

spaetz osm at sspaeth.de
Mon Sep 1 17:17:56 BST 2008


On Mon, Sep 01, 2008 at 05:24:46PM +0200, Dirk-L?der Kreie wrote:
>> Does this make sense to you? If you don't like that, the alternative would 
>> be to create the .zip file in "WorkingDirectory" and move to /uploaded 
>> when finished. I don't care which solution is used.
>
> I vote for working directory, because there are implementations of "zip" 
> around that will auto-add a ".zip" suffix.

OK, feel free to change. Otherwise I will get to it in the course of this week.

>>> The "old" client just had a number suffix (before the .zip suffix) in 
>>> case there would be more than one zip with the same name, to avoid 
>>> multiple tilesets in one zip or otherwise mangled zip files.
>> It's not to avoid multiple files with the same  name, it's to prevent 
>> uploaders to pick up partially written zip files.
>>  They only have the same name now if the same client (client_uuid) 
>> produces the same layer tileset multiple tiimes in a row. And then 
>> overwriting the old file is a welcome effect.
>
> It will not be overwritten but the contents updated. Not sure this will 
> always do what you want.

Probably not. But by zipping to the WorkingDir and then mrename'ing it to /uploaded that would never occur.

spaetz




More information about the Tilesathome mailing list