[OSM-dev] Josm-patches

Marcus Wolschon marcus at wolschon.biz
Tue Oct 2 10:08:53 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Frederik Ramm schrieb:
> Hi,
> 
>> I offer to refactor some of the josm-code to have
>> getters+setters (instead of public properties), parameter-checking,
>> error-messages and exception-handling after I'm back from vacation
>> next week.
> 
> No, please don't do that. Having public properties and very little  
> exception stuff is a deliberate design choice that Imi made and it  
> worked well for us. I know that it is not exactly popular in Java  
> circles but Imi had good reasons for it, and it is not ok to just  
> throw all this overboard in order to make Eclipse happy. (And it  
> doesn't paint JOSM code red with the default settings I am using..?)

Hi,

I'm using checkstyle because it is required for my customers projects.
If it's not wanted, I'm fine with it.
I just experienced that it did make debugging very hard (e.g. Getting
NullPointerExceptions with no line-number as the only indication what
went wrong. In that case it could have been checked easily a few lines
before during initialisation of the preferences-dialogue.).

Just my 2ct,
Marcus
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHAgqlf1hPnk3Z0cQRAvUjAJ41WpCUFaNggMTUkbLeqmYMvN48wACgjglv
axfTESsz8QayQxAWEmsH1p4=
=Tv/x
-----END PGP SIGNATURE-----




More information about the dev mailing list