[OSM-dev] Patch for Osmosis--complete ways and relations

[Karl Newman]

On 10/23/07, Brett Henderson <brett at bretth.com> wrote:
> Karl Newman wrote:
> > Sorry about that. I haven't done much real-world object-oriented
> > programming, but I've read a lot of code so I can recognize design
> > patterns, etc. I just don't have the experience to say "Ah, I could
> > use X pattern here".
> >
> What you've written is good.  It's all encapsulated within the
> AreaFilter class so it's easy to change later if complexity becomes an
> issue.

That's sort of what I figured when I wrote it, so I didn't worry too
much about the style.

> I originally intended people to be able to write their own external
> plugins so most of it is already there.  The main class that would need
> updating is the TaskRegistrar class which currently hard codes all the
> available tasks.  Probably wouldn't be hard to make it load tasks from a
> file.  It just hasn't been needed yet :-)  If you do wish to plug it
> into the existing pipeline framework, let me know.

Yes, the TaskRegistrar is where I was looking that made me think it
would be a fairly simple change. The plugin mechanism I had in mind
was just to have a "plugins" directory where jars could be dropped,
then they could be automatically detected and loaded by Osmosis (note:
I don't know how dynamic jar loading works), which would prompt them
to register their tasks and associated factories and then set up the
pipelines accordingly. This would be simpler than having to maintain
an additional text file.

> I'll probably delete the 0.4 tasks soon so I wouldn't worry about
> updating them.

That's what I figured. Thanks!