[josm-dev] Request for review of plugins

[Marián Kyral]

Dne 25.2.2014 10:34, Dirk Stöcker napsal:
> On Tue, 25 Feb 2014, Marián Kyral wrote:
> 
>> Both plugins were discussed and tested by Czech OSM community 
>> (talk-cz@) and
>> are regularly used by several users. I think that now are both plugins 
>> stable
>> enough to include them in JOSM repository (and fix the annoying 
>> missing
>> version issue).
> 
> See
> https://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins
> 

Yes, I read this page, several times ;-)
I think, it needs some improvements. E.g.: how to handle version in 
manifest for new plugin without commit to svn (se below).

> Some notes:
> a) You aren't required to have plugins in OSM-SVN. External plugins are
> also supported, see https://josm.openstreetmap.de/wiki/Plugins , but 
> SVN
> has some advantages (like translations).

No I aren't, but in case of Tracer plugin it is much better to update 
the source. It will avoid all possible future issues.
I would like to keep git and sync it with the JOSM svn (via git-svn or 
by applying patches)

Teoretically, I could manage PoinInfo externally, but I have an issue 
with versions in Manifest file. I tried git mirror - but I was not able 
to compile plugins. Now I'm using svn tree, but ant requires at least 
one commit of the new plugin, otherwise "ant dist" fails in target 
init-svn-revision-xml
I have no idea how to fix it without commit to JOSM svn. As an 
workaround, I've changed <arg value="."/> to <arg value="../tracer"/>.

> 
> b) If your code is an extension of Tracer plugin without breaking 
> existing
> functionality, I'd vote for updating the existing plugin instead of a 
> new
> one. If Tracer and Tracer2 can be joined I'd also would welcome that. 
> It's
> confusing for users to have multiple plugins with the same goal.

Tracer2 plugin uses rewritten .Net server. Allows user to define more 
sources of bitmaps. I did not tested deeply, but one user on talk-cz 
told me, that he prefers original Tracer as the results are better. 
Maybe it is just an issue with configuration, or it is a bug. I could 
ask him for some examples if needed.

Initially I planned to do a third Tracer plugin ;-), then I decided to 
merge it with original Tracer and later on I've found that there is 
Tracer2 also.
In theory Tracer and Tracer2 plugins could be merged in future, but 
currently Tracer plugin is focused mainly to Czech specific cases 
(Especially the RUIAN mode - server is sending not only geometry, but 
also additional attributes.) and Tracer2 is much more universal.


> 
> c) Regarding shortcuts, have a look at
> https://josm.openstreetmap.de/wiki/DevelopersGuide/ShortcutsList :-)
> 

Yes, shortcuts. My nightmare :-( For Tracer, I wanted to stay close to 
"T", for pointInfo I wanted something that could be easily pressed by 
left hand. The only good news is, that user could change shortcut when 
needed (even they don't know about this possibility).

>> As I'm not a java programmer, I'm asking for code review and for help 
>> with
>> commiting to JOSM tree.
> 
> I also was no Java programmer before starting with JOSM. We wont cut 
> your
> head if you make errors. Testing with multiple users sounds already 
> like a
> very good approach.

Good to hear :-D

Marián