[openstreetmap-website] Allow cross-origin request to API (#138)

Tom Hughes notifications at github.com
Sun Oct 21 21:55:18 GMT 2012


> @@ -0,0 +1,31 @@
> +require File.dirname(__FILE__) + '/../test_helper'
> +
> +class CORSTest < ActionController::IntegrationTest
> +  # https://github.com/rails/rails/commit/ad46884af567d6f8d6d8d777f372c39e81a560ba

I don't see how this code relates to the above commit, other than that both implement an `options` method - the actual code seems to be completely different?

Other than that my only comment would be that I'd prefer to see monkey patch somewhere more generic - either as an initializer or maybe in the test helper, rather than in a specific test like this. 

---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/138/files#r1899339
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20121021/7292c960/attachment.html>


More information about the rails-dev mailing list