[openstreetmap/openstreetmap-website] Enable the app to be built using Docker (#1290)
Seth Fitzsimmons
notifications at github.com
Mon Oct 31 21:26:10 UTC 2016
mojodna commented on this pull request.
(Sorry, didn't mean to trigger a review on this.)
> + libpq-dev \
+ libxml2-dev \
+ imagemagick \
+ libmagickwand-dev \
+ postgresql-client \
+ nodejs \
+ file
+
+# Setup app location
+RUN mkdir -p /app
+WORKDIR /app
+
+# Install gems
+ADD Gemfile /app/Gemfile
+ADD Gemfile.lock /app/Gemfile.lock
+RUN bundle install
(Commenting here because it's the end of the file.)
`COPY . /app` should be included if this image is intended to be used independently of a local git clone, otherwise none of the source files will be available in the image.
(This can co-exist happily with mapping `$(pwd)` to `/app` as a volume; files present in the image will be shadowed by local paths.)
> + libpq-dev \
+ libxml2-dev \
+ imagemagick \
+ libmagickwand-dev \
+ postgresql-client \
+ nodejs \
+ file
+
+# Setup app location
+RUN mkdir -p /app
+WORKDIR /app
+
+# Install gems
+ADD Gemfile /app/Gemfile
+ADD Gemfile.lock /app/Gemfile.lock
+RUN bundle install
Also consider adding `-j $(nproc)` as an argument to speed up gem installation (it will run a number of processes matching the cores available on the system doing the building).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1290#pullrequestreview-6528675
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20161031/f82e4a28/attachment.html>
More information about the rails-dev
mailing list