[openstreetmap/openstreetmap-website] Allow the hiding of changeset tags (#1167)

Frederik Ramm notifications at github.com
Wed Dec 6 21:36:43 UTC 2017

Uh, I had completely forgotten that I ever wrote this, and I can't believe I didn't somehow add an "if moderator" check but reviewing the changes now it seems I indeed haven't. Sorry for that. 

What I wanted to achieve with this was a really lightweight way of "not blasting out advertising through our web site". I view any kind of redaction as a heavy-handed meddling with our data that leads to inconsistencies with the history (someone might once have taken a snapshot of our data and now even our historic data doesn't fit the snapshot any more), and would reserve that for really important cases. For a mere advertising slogan, suppressing its publication on the web page seemed the better alternative; it's not something so evil that it must be hidden from everyone even when accessing the API. 

What I wanted was cosmetics, whereas redaction is surgery. 

I don't have strong feelings either way. I can see how my lightweight approach might seem unsatisfactory from a data model perspective because it introduces a hitherto unknown "this exists but isn't shown on the web page" state. What I submitted was simply the best I could come up in the short time I had allowed myself.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20171206/7977e09e/attachment.html>

More information about the rails-dev mailing list