[openstreetmap/openstreetmap-website] Dressed up notification mails (#1401)

[saintamh]

@pnorman thanks for the valuable feedback!

> Shouldn't thin use image_path or something? Explicitly building a path to an asset like that seems wrong.

I'll look into `image_path`.

> can't we add it as part of the commenter expansion and achieve the same result?

Yes, that sounds like it would make sense. As I wrote above, I too am not comfortable with having HTML/CSS in the locale files. I'll move the HTML bits to Rubyland, which feels.. less wrong?

I'd rather keep the `<strong>` emphasis on the user name, though, I think it makes sense for that information to stand out. Unless others disagree?

> Is there something clever we can do here with a layout?

Aha, I think "layouts" might be the Rails keyword I was missing for the template-template I was trying to describe above -- I'll look that up.
 
I'll try to implement the above in the coming days.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1401#issuecomment-269951125
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20170102/485becba/attachment.html>