[openstreetmap/openstreetmap-website] Update to rails 6 (#2423)

[Tom Hughes]

This is a first cut at updating to rails 6 now that 6.0.1 is available which resolves a bug that was affecting us.

I have dropped `record_tag_helper` which we were only using in one place and which is still awaiting a new release.

The other thing where a new release is pending is `actionpack-page_caching` so I have disabled that for now so that we can get on with testing as it is only used as an optimisation in production for the embed page.

A test site is deployed at https://rails6.apis.dev.openstreetmap.org/ so that we can give it the once over.

Fixes #2352 
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2423

-- Commit Summary --

  * Disable page caching
  * Update to rails 6.0.1
  * Fix some deprecation warnings
  * Errors have text/plain as the content type
  * Drop use of record_tag_helper

-- File Changes --

    M Gemfile (17)
    M Gemfile.lock (144)
    M app/controllers/export_controller.rb (2)
    M app/mailers/notifier.rb (2)
    M app/views/oauth_clients/index.html.erb (4)
    M bin/setup (12)
    M config/environments/development.rb (7)
    M config/environments/production.rb (39)
    M config/environments/test.rb (20)
    M config/initializers/active_storage.rb (6)
    M config/initializers/assets.rb (2)
    M config/initializers/content_security_policy.rb (5)
    M config/initializers/cors.rb (4)
    M config/initializers/field_error.rb (2)
    A config/initializers/new_framework_defaults_5_2.rb (38)
    A config/initializers/new_framework_defaults_6_0.rb (45)
    M config/initializers/wrap_parameters.rb (2)
    M config/puma.rb (10)
    A db/migrate/20190820192641_add_foreign_key_constraint_to_active_storage_attachments_for_blob_id.active_storage.rb (8)
    M db/structure.sql (5)
    M lib/redactable.rb (2)
    M test/controllers/api/notes_controller_test.rb (90)
    M test/controllers/api/traces_controller_test.rb (4)
    M test/controllers/api/user_preferences_controller_test.rb (14)
    M test/controllers/api/users_controller_test.rb (12)
    M test/controllers/changeset_comments_controller_test.rb (6)
    M test/controllers/changesets_controller_test.rb (6)
    M test/controllers/traces_controller_test.rb (10)
    M test/integration/cors_test.rb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2423.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2423.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2423
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191105/ad33cb04/attachment-0001.html>