[openstreetmap/openstreetmap-website] Update to rails 6 (#2423)

[Andy Allan]

gravitystorm commented on this pull request.

The migration appears to be unnecessary for our situation, since we started with a version of ActiveStorage that includes the foreign key. But I guess the app:upgrade auto-generated that anyway, and no harm either way.

Everything else looks fine to me. There's a deprecation warning from jsonify but that's not a blocker and can be dealt with separately.

>    config.middleware.use I18n::JS::Middleware
 
-  # Raises error for missing translations
-  config.action_view.raise_on_missing_translations = true
+  # Raises error for missing translations.
+  # config.action_view.raise_on_missing_translations = true

Is this a deliberate change? I think it's quite useful for the tests to fail if a translation is used in a view but there's no entry in config/locales/en.yml

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2423#pullrequestreview-316101989
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191113/c4b044fa/attachment-0001.html>