[openstreetmap/openstreetmap-website] Make account deletion remove the email address when possible (PR #3488)

[Andy Allan]

@gravitystorm commented on this pull request.

Are we making this too complicated? This was on my todo list but I haven't fully thought it out yet. My initial reaction is that I thought we were going to end up with two states:

a) We need to retain the account, and so we retain the email address
b) We don't need to retain the account, and so the email address disappears at the point that we "properly destroy" the account.

But here we are working where we need to keep the account but don't need to keep the email address. I guess this is to avoid notes, diary entries etc disappearing. I guess we should define exactly why we need to retain the email, which I think includes for relicensing issues, right? If so, do we need to include "has a trace?", since that's user generated data the we currently license too, that's not covered by changesets.

My other thought is whether some of this could be implemented with a delay, to give time for abuse investigations, e.g. disable the account immediately and then properly destroy it after 14 days.

But again, we should probably make a list of any reasons for retaining the email address, since that might guide the implementation.

> @@ -21,6 +21,9 @@
 <ul>
   <li><%= t ".delete_profile" %></li>
   <li><%= t ".delete_display_name" %></li>
+  <% unless current_user.changesets.exists? -%>

My initial thought is that we should abstract this slightly, e.g. `unless current_user.must_retain_email?` or similar. As per simonpoole's comment, there might be other situations where we need to retain the email.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3488#pullrequestreview-900101733
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3488/review/900101733 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220304/7cb1cb03/attachment-0001.htm>