[openstreetmap/openstreetmap-website] Upgrade to rails 7.1.0 (PR #4278)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -138,7 +138,7 @@ def test_create_invalid_xml
       xml = "<osm><node lat='#{lat}' lon='#{lon}' changeset='#{changeset.id}'><tag k='foo' v='#{'x' * 256}'/></node></osm>"
       put node_create_path, :params => xml, :headers => auth_header
       assert_response :bad_request, "node upload did not return bad_request status"
-      assert_equal ["NodeTag ", " v: is too long (maximum is 255 characters) (\"#{'x' * 256}\")"], @response.body.split(/[0-9]+,foo:/)

I remembered the details slightly wrong... This is what it used to look like:

```
NodeTag 14,foo: v: is too long (maximum is 255 characters)
```

and now:

```
NodeTag [38, "foo"]: v: is too long (maximum is 255 characters)
```

which is all down to how rails default error handling (augmented by CPK in the old code) represents a composite key in a validation failure which I'm not sure we can do much about?

Are users really supposed to be parsing this?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355570644
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4278/review/1672219180 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231011/081e1982/attachment-0001.htm>