[openstreetmap/openstreetmap-website] Upgrade to rails 7.1.0 (PR #4278)

mmd notifications at github.com
Wed Oct 11 20:36:56 UTC 2023


@mmd-osm commented on this pull request.



> @@ -138,7 +138,7 @@ def test_create_invalid_xml
       xml = "<osm><node lat='#{lat}' lon='#{lon}' changeset='#{changeset.id}'><tag k='foo' v='#{'x' * 256}'/></node></osm>"
       put node_create_path, :params => xml, :headers => auth_header
       assert_response :bad_request, "node upload did not return bad_request status"
-      assert_equal ["NodeTag ", " v: is too long (maximum is 255 characters) (\"#{'x' * 256}\")"], @response.body.split(/[0-9]+,foo:/)

FWIW: I invented my own error messages in cgimap for keys/values exceeding 255 chars, and nobody seemed to have an issue with it. That's for the diff upload, though.

Error messages are: _Key has more than 255 unicode characters_ and _Value has more than 255 unicode characters_.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355752853
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4278/review/1672540332 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231011/7d544a51/attachment.htm>


More information about the rails-dev mailing list