[openstreetmap/openstreetmap-website] Add system test with osm website oauth app registration (PR #4436)

[Tom Hughes]

@tomhughes commented on this pull request.



>      visit oauth_authorized_applications_path
 
+    accept_alert do
+      click_link "Revoke Access"
+    end

Rather than adding this (and the comment above) all of which took me a few minutes to understand, wouldn't it be simpler just to change the assert below to expect an application?

This test is just trying to check that the authorized applications page exists and displays rather than the specific contents...

An alternative which would be clearer would be to drop the comment and add an assertion above the revoke to check that the website application is listed and then revoke it and check you get the no apps message?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4436#pullrequestreview-1807777642
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4436/review/1807777642 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240107/bf4c9d5d/attachment-0001.htm>