[openstreetmap/openstreetmap-website] Make Docker Image use Node.js v18 (PR #4992)

[Emin Kocan]

This PR addresses #4989. 
Errors are encountered when attempting to run `bundle exec rails eslint` inside the Docker container terminal,after following the instructions in the `DOCKER.md` file.

After updating `DOCKER.md` to use Node.js v18, we can rebuild the container using `docker compose up --build -d ` command. Resulting in expected result when running `bundle exec rails eslint`

```bash
$ bundle exec rails eslint
warning: parser/current is loading parser/ruby30, which recognizes 3.0.7-compliant syntax, but you are running 3.0.2.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
yarn run v1.22.22
$ /app/node_modules/.bin/eslint -c /app/config/eslint.js /app/app/assets/config/manifest.js /app/app/assets/javascripts/application.js /app/app/assets/javascripts/auth_providers.js /app/app/assets/javascripts/diary_entry.js /app/app/assets/javascripts/fixthemap.js /app/app/assets/javascripts/id.js /app/app/assets/javascripts/index/changeset.js /app/app/assets/javascripts/index/contextmenu.js /app/app/assets/javascripts/index/directions/fossgis_osrm.js /app/app/assets/javascripts/index/directions/fossgis_valhalla.js /app/app/assets/javascripts/index/directions/graphhopper.js /app/app/assets/javascripts/index/directions.js /app/app/assets/javascripts/index/export.js /app/app/assets/javascripts/index/history.js /app/app/assets/javascripts/index/layers/data.js /app/app/assets/javascripts/index/layers/notes.js /app/app/assets/javascripts/index/new_note.js /app/app/assets/javascripts/index/note.js /app/app/assets/javascripts/index/query.js /app/app/assets/javascripts/index/search.js /app/app/assets/javascripts/index.js /app/app/assets/javascripts/leaflet.key.js /app/app/assets/javascripts/leaflet.layers.js /app/app/assets/javascripts/leaflet.locate.js /app/app/assets/javascripts/leaflet.map.js /app/app/assets/javascripts/leaflet.note.js /app/app/assets/javascripts/leaflet.query.js /app/app/assets/javascripts/leaflet.share.js /app/app/assets/javascripts/leaflet.sidebar-pane.js /app/app/assets/javascripts/leaflet.sidebar.js /app/app/assets/javascripts/leaflet.zoom.js /app/app/assets/javascripts/login.js /app/app/assets/javascripts/matomo.js /app/app/assets/javascripts/messages.js /app/app/assets/javascripts/oauth.js /app/app/assets/javascripts/richtext.js /app/app/assets/javascripts/router.js /app/app/assets/javascripts/user.js /app/app/assets/javascripts/welcome.js /app/config/eslint.js

/app/app/assets/javascripts/index.js
  267:9  warning  Unexpected alert  no-alert

/app/app/assets/javascripts/index/directions.js
  117:11  warning  Unexpected alert                                                         no-alert
  337:9   warning  Unexpected 'todo' comment: 'TODO: collapse width of sidebar back to...'  no-warning-comments

/app/app/assets/javascripts/index/directions/fossgis_osrm.js
  4:1  warning  Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable  no-implicit-globals

/app/app/assets/javascripts/index/directions/fossgis_valhalla.js
  1:1  warning  Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable  no-implicit-globals

/app/app/assets/javascripts/index/directions/graphhopper.js
   1:1   warning  Unexpected function declaration in the global scope, wrap in an IIFE for a local variable, assign as global property for a global variable  no-implicit-globals
  68:17  warning  Unexpected 'todo' comment: 'TODO does graphhopper map instructions...'                                                                      no-warning-comments

✖ 7 problems (0 errors, 7 warnings)

Done in 0.99s.
# 
```
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4992

-- Commit Summary --

  * make docker image use nodejs v18

-- File Changes --

    M Dockerfile (12)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4992.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4992.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4992
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4992 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240715/405b268c/attachment-0001.htm>