[openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)
Anton Khorev
notifications at github.com
Sat Apr 12 13:41:45 UTC 2025
@AntonKhorev commented on this pull request.
> @@ -5,16 +5,16 @@ class IndexTest < ApplicationSystemTestCase
node = create(:node)
visit node_path(node)
assert_selector "#content.overlay-right-sidebar"
- find(".icon.share").click
+ find(".control-share a").click
If we want tests not failing on intermediate commits, [Click links instead of icons in tests](https://github.com/openstreetmap/openstreetmap-website/pull/5752/commits/43c3a7cb8b8e5ce96cbcb15b96f679fbb5b7506c) should be squashed into [Unify active control button behaviour](https://github.com/openstreetmap/openstreetmap-website/pull/5752/commits/8b59047a1cd593e0b077dc503b0ea3a6461ef472).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2762165385
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5752/review/2762165385 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250412/e5f1e06a/attachment.htm>
More information about the rails-dev
mailing list