[openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

Anton Khorev notifications at github.com
Sat Apr 12 14:14:10 UTC 2025


@AntonKhorev commented on this pull request.



> +    <p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => tag.a(render(:partial => "layouts/note_icon"),
+                                                                                :class => "icon note",

Continuing https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2021990094

Do you still think you need map control icons in three different places as opposed to one, which you could use like this:

```suggestion
    <% note_icon = capture do %>
      <%= tag.a :class => "icon note", :title => t("javascripts.site.createnote_tooltip") do %>
        <svg width="20" height="20"><use href="#icon-note" /></svg>
      <% end %>
    <% end %>
    <p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => note_icon %></p>
```

(this is ignoring that you changed how this link looks)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2762170694
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5752/review/2762170694 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250412/5531ed2b/attachment.htm>


More information about the rails-dev mailing list