[openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

[Marwin Hochfelsner]

@hlfan commented on this pull request.



> +    <p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => tag.a(render(:partial => "layouts/note_icon"),
+                                                                                :class => "icon note",

Well, I do think the icons should only be defined once. In an SVG each, so only the necessary icons are put into the views.
But while #5880 is stalling, would it be ok to define the icons like this?
https://github.com/openstreetmap/openstreetmap-website/blob/cb0e3d3575da000e9dbbde31bc85efc7a7f66a5d/app/views/layouts/_defs_markers.html.erb#L15-L24

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2040677421
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5752/review/2762182611 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250412/3b0684bd/attachment.htm>