[openstreetmap/openstreetmap-website] Contribution guidelines are not clear about presenting a clean commit history (Issue #6592)

Pablo Brasero notifications at github.com
Fri Dec 5 11:52:23 UTC 2025


pablobm created an issue (openstreetmap/openstreetmap-website#6592)

It's common for PR reviewers to request that commits be squashed into a cleaner form, eliminating fixup commits and presenting a more consistent history. However this is not that clear in the contribution guidelines at [CONTRIBUTING.md](https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md)

For example, the advice to «[a]void including "fixup" commits» only appears under a section about "large pull requests", failing to make it clear that is should apply to others.

Also a pet peeve of mine: I would add advice for contributors not to work on `master` for their changes. Might as well include it in the guidelines too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6592
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/6592 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251205/3d3fbd54/attachment.htm>


More information about the rails-dev mailing list