[openstreetmap/openstreetmap-website] Consolidate leaflet marker creation in OSM.getMarker (PR #5860)

[Marwin Hochfelsner]

OSM.getUserIcon() was used for much more than just the icons on the user page.
I've made it work with the icon paths already stored in the OSM object and made it compatible with the note icons to eliminate the `noteIcons` objects.

I previously included this in #5854, but I think it makes more sense as a separate PR.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5860

-- Commit Summary --

  * Consolidate leaflet marker creation in OSM.getMarker

-- File Changes --

    M app/assets/javascripts/diary_entry.js (4)
    M app/assets/javascripts/index/directions-endpoint.js (11)
    M app/assets/javascripts/index/directions.js (4)
    M app/assets/javascripts/index/home.js (2)
    M app/assets/javascripts/index/layers/notes.js (22)
    M app/assets/javascripts/index/new_note.js (22)
    M app/assets/javascripts/index/note.js (20)
    M app/assets/javascripts/index/search.js (2)
    M app/assets/javascripts/leaflet.map.js (22)
    M app/assets/javascripts/osm.js.erb (1)
    M app/assets/javascripts/user.js (4)
    M app/views/dashboards/_contact.html.erb (2)
    M app/views/dashboards/show.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5860.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5860.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5860
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5860 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250328/37a366c1/attachment.htm>