[Rebuild] Real-world example for test suite: Non-agreer's way completely changed by agreers including highway and name tags
Spod OSM
spodosm at gmail.com
Thu Apr 19 13:41:00 BST 2012
I took a look at the code in Git, but couldn't really work out if this
case is covered yet, and the syntax of the tests is a bit too opaque
for me to work out in the time I've got. So, hopefully someone else
can add a test based on this info!
Version 13 of way 5000022 can be used to make a test for a way that
should not be deleted.
It was created by a non-agreer, with tags "highway=secondary" and
"name=Westgate", both of which have now been corrected by agreers to
be "highway=tertiary" and "name=Sheffield Road".
All edits except the creation are by agreers.
All the tags from the original non-agreer have been deleted or the
values of the tags have changed.
All of the original non-agreer's nodes have either been deleted or
moved.
The main thing that this test should show, is that changing the name
tag to a completely different name (not just a spelling correction)
and changing the class of highway (again, not just a spelling
correction) should clean those tags, so the way will not be deleted.
http://osm.mapki.com/history/way.php?id=5000022
I was leaving this way without an "odbl=clean" tag, as a test for the
redaction tool, but another user has added an "odbl=clean" tag in
version 14, so wfte and the other visualisation tools now show this
way to be safe. However, before the addition of the "odbl=clean" tag,
the tools were showing the way as being tainted (because they weren't
looking at the tags to see if they had been changed by agreers as they
have).
Version 13 is the version to use in a test.
Thanks,
Spod
More information about the Rebuild
mailing list