[Tile-serving] [osm2pgsql] Add cmake build scripts and appveyor.yml (#460)
Paul Norman
notifications at github.com
Wed Oct 21 09:05:51 UTC 2015
> put #define `_LARGEFILE_SOURCE` in `config.h`.
I think we could just leave it where it is, it's only needed for `lseek64` which is only in the flat-nodes code, and it only matters on 32-bit machines.
> Let's add `-Wall` to cmake then
Is there not a compiler-independent way of enabling warnings? Not all compilers use `-Wall` for all warnings.
> What about optimizations, debugging info
Our autotools setup doesn't really have release vs debug builds, so the cmake behavior seems sane. We might need to come back and tweak it. The one thing I'm not sure about is omitting debug info for release builds.
We should document how to do both a debug and a release build.
> geos-fallback?
Not needed on Ubuntu 12.04 anymore, so I'm fine with completely removing the files and any reference to them, but it'll need testing. If you don't want to do that in the scope of this PR, you could just replicate the current behavior.
---
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/460#issuecomment-149828110
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20151021/73c302b6/attachment.html>
More information about the Tile-serving
mailing list