[Tile-serving] [openstreetmap/osm2pgsql] Use fmt library instead of boost::format (#1004)

[Sarah Hoffmann]

lonvia commented on this pull request.



>                  "    WHERE ST_IsValid(way)\n"
                 "    ORDER BY "
                 "ST_GeoHash(ST_Transform(ST_Envelope(way),4326),10)\n"
                 "    COLLATE \"C\"",
                 m_target->name, m_table_space);
             m_sql_conn->exec("RESET client_min_messages");
         }
-        m_sql_conn->exec("DROP TABLE %1%", m_target->name);
-        m_sql_conn->exec("ALTER TABLE %1%_tmp RENAME TO %1%", m_target->name);
+        m_sql_conn->exec("DROP TABLE {}", m_target->name);
+        m_sql_conn->exec("ALTER TABLE {}_tmp RENAME TO {}", m_target->name);

second parameter missing

> @@ -207,17 +202,17 @@ void table_t::stop(bool updateable, bool enable_hstore_index,
                in OSM. */
             m_sql_conn->exec("SET client_min_messages = WARNING");
             m_sql_conn->exec(
-                "CREATE TABLE %1%_tmp %2% AS\n"
-                "  SELECT * FROM %1%\n"
+                "CREATE TABLE {}_tmp {} AS\n"
+                "  SELECT * FROM {}\n"

parameter missing

>                                   "    FOR EACH ROW EXECUTE PROCEDURE "
-                                 "%1%_osm2pgsql_valid();",
+                                 "{}_osm2pgsql_valid();",

parameter missing

> @@ -182,9 +182,9 @@ TEST_CASE("db_copy_mgr_t")
 
         auto c = db.connect();
 
-        auto sql = boost::format("SELECT h->'%1%' from test_copy_mgr");
+        std::string const sql{"SELECT h->'{}' FROM test_copy_mgr"};

char const *?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1004#pullrequestreview-323250133
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20191126/dce70526/attachment.html>