[Tile-serving] [openstreetmap/osm2pgsql] Use fmt library instead of boost::format (#1004)

[Sarah Hoffmann]

lonvia commented on this pull request.



>              }
             for (size_t i = 0; i < hstore_columns.size(); ++i) {
-                m_sql_conn->exec("CREATE INDEX ON %1% USING GIN (\"%3%\") %4%",
-                                 m_target->name, i, hstore_columns[i],
-                                 (table_space_index
-                                      ? "TABLESPACE " + table_space_index.get()
-                                      : ""));
+                m_sql_conn->exec(
+                    "CREATE INDEX ON {} USING GIN (\"{}\") {}"_format(
+                        m_target->name, i, hstore_columns[i],

'i' needs to be removed. There is no %2% in the original anymore. I'm mildly surprised that the tests didn't catch that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/osm2pgsql/pull/1004#pullrequestreview-324469282
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/tile-serving/attachments/20191128/cfeb9677/attachment.html>